Skip to content

Custom Field export#1126

Merged
RemDelaporteMathurin merged 14 commits intomainfrom
custom-field
Apr 28, 2026
Merged

Custom Field export#1126
RemDelaporteMathurin merged 14 commits intomainfrom
custom-field

Conversation

@RemDelaporteMathurin
Copy link
Copy Markdown
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin commented Apr 23, 2026 •
edited
Loading

Description

TODO:

  • Discontinuous problem support
  • Documentation/Usage

Summary

Related Issues

Fixes #1125

Motivation and Context

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔨 Code refactoring (no functional changes, no API changes)
  • 📝 Documentation update
  • ✅ Test update (adding missing tests or correcting existing tests)
  • 🔧 Build/CI configuration change

Testing

  • All existing tests pass locally (pytest)
  • I have added new tests that prove my fix is effective or that my feature works

Code Quality Checklist

  • My code follows the code style of this project (Ruff formatted: ruff format .)
  • My code passes linting checks (ruff check .)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Documentation

  • I have updated the documentation accordingly (if applicable)
  • I have added docstrings to new functions/classes following the project conventions

Breaking Changes

Screenshots/Examples

Additional Notes

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 97.14286% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.90%. Comparing base (3d92caf) to head (78f648c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/festim/exports/vtx.py 97.87% 1 Missing ⚠️
src/festim/hydrogen_transport_problem.py 95.23% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1126      +/-   ##
==========================================
+ Coverage   94.80%   94.90%   +0.09%     
==========================================
  Files          44       44              
  Lines        3310     3374      +64     
==========================================
+ Hits         3138     3202      +64     
  Misses        172      172

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RemDelaporteMathurin RemDelaporteMathurin marked this pull request as ready for review April 24, 2026 15:40
@RemDelaporteMathurin
Copy link
Copy Markdown
Collaborator Author

RemDelaporteMathurin commented Apr 24, 2026

@jhdark can you please review this?

jhdark
jhdark reviewed Apr 28, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@jhdark jhdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! maybe a different name for the class though?

Comment thread src/festim/exports/vtx.py Outdated
@RemDelaporteMathurin RemDelaporteMathurin merged commit 39645c0 into main Apr 28, 2026
16 of 18 checks passed
@RemDelaporteMathurin RemDelaporteMathurin deleted the custom-field branch April 28, 2026 16:58
@RemDelaporteMathurin RemDelaporteMathurin mentioned this pull request Apr 28, 2026
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhdark jhdark jhdark left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for custom Function calculations as exports

2 participants

@RemDelaporteMathurin @jhdark